-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mlos_bench: error handling improvements #523
Comments
One thing that might make this easier to implement is if we clearly separated the phases of "setup" (e.g., basic system preparation) vs. "configure" (e.g., configure the target system with the tunables). That way, if "setup" failed, we could alert that the script was the problem, whereas if "configure" failed, we could inform the optimizer that it was a bad region. See Also: #498 |
4 tasks
Closed
bpkroth
added a commit
that referenced
this issue
Aug 20, 2024
The `mlos_bench` CLI wrapper exits non-zero currently even on success. This PR adds some basic sanity checks and makes sure we exit 0 when the process looks roughly OK. Further work to be expanded in #523. --------- Co-authored-by: Sergiy Matusevych <[email protected]> Co-authored-by: Sergiy Matusevych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes user scripts don't return a
score
value, even though they exit 0 (indicating SUCCESS).In that case we can do a couple of things:
for instance, tolerate no more than N "bad" configs in a row before we assume its a script error and abort entirely to notify the user that they should manually inspect and deal with things
The text was updated successfully, but these errors were encountered: