Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mlos_bench: improve relative paths in configs #330

Open
bpkroth opened this issue May 3, 2023 · 1 comment
Open

mlos_bench: improve relative paths in configs #330

bpkroth opened this issue May 3, 2023 · 1 comment

Comments

@bpkroth
Copy link
Contributor

bpkroth commented May 3, 2023 •
edited
Loading

It might be nice if the path resolution logic for a config allowed for paths relative to that config file (e.g. to reference scripts within that directory) as opposed to the full path within either the repo or the search path setup by the user config.

Forked off from #313
@bpkroth
Copy link
Contributor Author

bpkroth commented Nov 3, 2023 •
edited
Loading

Added some initial work on this here: main...bpkroth:local-path-resolution-improvements, but it will require some signature changes in many places, so will come back to it another time.

@bpkroth bpkroth mentioned this issue Sep 23, 2024
Merged
bpkroth added a commit that referenced this issue Sep 24, 2024
@bpkroth
Tweaks for some pylint warnings (#858)
fcc49aa 
Minor adjustments to both display in vscode and quiet some pylint
warnings.

Note: in the future I'd like to get some changes from #330 incorporated
to allow more self-contained config examples, with relative paths
support, added, which means changing a pile of APIs, in which case we
can probably make all of these require named position values and remove
those exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

local-path-resolution-improvements bpkroth/MLOS
1 participant
@bpkroth