-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIEngine: New methods and framework update #1437
Merged
gregg-miskelly
merged 13 commits into
microsoft:main
from
intel-rganesh:New-methods-and-framework-update
Mar 6, 2024
Merged
MIEngine: New methods and framework update #1437
gregg-miskelly
merged 13 commits into
microsoft:main
from
intel-rganesh:New-methods-and-framework-update
Mar 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MI Commands are executed in a way that it always appends some result-class alongside some other format in the ToString override method. There should be an option to execute MI Commands using CmdAsync alone. Signed-off-by: intel-rganesh [email protected]
Correct VSIX file so IDE plugin integration is performed for ALL users. Signed-off-by: intel-rganesh [email protected]
By default VS does not have .net framework 4.6.2 installed, minimum we support is 4.7.2. Signed-off-by: intel-rganesh [email protected]
Add GetProcessState for querying the status of the debugger. Signed-off-by: intel-rganesh [email protected]
In GetThreadContext do not proceed if the thread is null. Signed-off-by: intel-rganesh [email protected]
WardenGnaw
approved these changes
Jan 26, 2024
Use ArgumentOutOfRangeException instead of returning null when the command does not begin with "-". Signed-off-by: intel-rganesh [email protected]
b2104ba
to
03c4040
Compare
Removing ViewSelectedThreadInfo as part of review comments. Signed-off-by: intel-rganesh [email protected]
gregg-miskelly
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers the following commits:
Signed-off-by: intel-rganesh [email protected]