Merge main into release-cpptools #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update version to 17.8
Co-authored-by: Andrew Wang <[email protected]>
DAR failed to set the encoding to UTF-8, leading to corrupt messages if we tried to marshal non-ascii strings.
* Only use ps 'flags' for macOS This PR adds in an operating system check via uname to determine if we should run the PS command with the 'flags' flag. This feature was originally used to determine the architecture of a process for macOS M1 machines that can run as x64 or as arm64. AD7Process only uses the flags field in macOS so this PR updates the command sent to only use it on macOS machines. Other changes: - Updated the setup.csx script to update VS with VS.list instead of VS.Codespaces.list - Updated tests to use the new PSOutputParser - Added a macOS test * Addressing PR issues
* Fixing File writing for EngineLogger With the Natvis Diagnostics Logger work, the file logger would fail since it would not close the file. This PR also runs 'File.CreateText' in MIDebugCommandDispatcher so errors can be caught earlier and not set an invalid file path.
…tAdd-Offset MIEngine: Fix Disassembly fail on GPU if startAddress is offset
Co-authored-by: Andrew Wang <[email protected]>
This PR addresses issues building MIEngine with .NET 8 SDK. See dotnet/sdk#34438
* MIEngine: Address is not an AD7MemoryAddress obj Handle condition where the address is not an AD7MemoryAddress object. On running multiple debug engines, it appears this gets called with a different object type. Signed-off-by: intel-rganesh [email protected] * MIEngine: Allow direct array evaluation Allow direct array eval in memory window. Signed-off-by: intel-rganesh [email protected] * MIEngine: Address review comments Address review comments for array evaluation and address check: 1> Use the correct constant in AD7Disassembly when pCodeContext is not AD7MemoryAddress. 2> Avoid creating new AD7Property to fetch variable information value. Signed-off-by: intel-rganesh [email protected] --------- Signed-off-by: intel-rganesh [email protected] Co-authored-by: Andrew Wang <[email protected]>
Do reverse sort of the `sourceMap`.
In my `launch.json` configuration I have the following `sourceFileMap`:
```
"sourceFileMap": {
"/usr/src/debug/my-project/git-r0/build/src/../../git": "${workspaceFolder}",
"/usr/src/debug": {
"editorPath": "${config:YOCTO_ARCH}",
"useForBreakpoints": false
}
},
```
The YOCTO_ARCH set in `settings.json` to:
```
"terminal.integrated.env.linux": {
"YOCTO_ARCH": "/home/mouse/linux-bsp/linux-devel-build/build/work/cortexa7t2hf-neon-vfpv4_linux-linux-gnueabi"
},
```
This PR addresses an issue encountered while debugging a binary that's running on a remote system and built using Yocto. Currently, when debugging, the source files are being referenced from the Yocto build tree instead of the local workspace. This issue prevents setting breakpoints effectively in the local workspace source files.
To resolve this, the change involves modifying the way source mappings are processed. Specifically, it proposes sorting the mappings in reverse order, starting with the longer, more specific paths and moving towards the more general ones. By doing this, the debugger will first consider the project-specific paths defined in `sourceFileMap`. If it doesn't find a match there, it will then fall back to the more general paths. This reverse sorting ensures that the local workspace sources are prioritized over the Yocto build tree sources, allowing for effective breakpoint setting and debugging in the local workspace.
Fix s32 format specifier support
* Theme Docker Container Selector Dialog This PR updates the Docker Container Selector Dialog in Visual Studio to be themed. The following changes were done: - Updates VS packages since some of the newer theming was in newer packages. - Newer packages had new attributes that needed to be handled with MakePIAPortableTool. - Converted ListBox to ListView for ContainerPickerDialog and modified associated automation peers * Address PR issues * Revert to 17.5.33428.366 * Remove Maximize Functionality * Address title bar issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.