Fix Remote AsyncBreak #1399
Merged
Fix Remote AsyncBreak #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5f6213c accidently broke async-break for gdb remote scenarios as we send "-exec-interrupt" for async-break instead of sending a 'kill SIGTRAP'. This PR detects that if we are in the remote scenario, we should also handle SIGINT as an async break.
paulmaybee
approved these changes
May 8, 2023
mpeyrotc
approved these changes
May 8, 2023
gregg-miskelly
approved these changes
May 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5f6213c accidently broke async-break for gdb remote scenarios as we send "-exec-interrupt" for async-break instead of sending a 'kill SIGTRAP'.
This PR modifies the
IsAsyncBreakSignalto return a newly created enumAsyncBreakSignal, and renames it toGetAsyncBreakSignal.GetAsyncBreakSignalwill now return if it saw aSIGINT,SIGTRAP, orNoneif its an unknown signal related to async break or no signal was retrieved at all.This will be used along with a new flag called
IsUsingExecInterrupt, which will be set before-exec-interruptis sent to the debugger.IsUsingExecInterruptwill be reset when the engine resolves theasync-breakfrom the user (see DebuggedProcess.cs changes) or when we are resolving an internal async break (See Debugger.cs DoInternalBreakActions).Resolves: #1382