Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into 'release-cpptools' for v1.15.0 #1384

Merged
merged 3 commits into from
Feb 8, 2023
Merged

Merge main into 'release-cpptools' for v1.15.0 #1384

merged 3 commits into from
Feb 8, 2023

Conversation

gc46
Copy link
Contributor

@gc46 gc46 commented Feb 8, 2023

No description provided.

WardenGnaw and others added 3 commits December 1, 2022 10:48
* Fix race on stopping monitor

This PR fixes the race condition when disposing of the RegistryMonitor
and when detecting the stop.

This PR modifies Dispose to call Stop() which will cause the wait
handler to fire and stop the Monitor thread which will properly dispose
of the object.
This PR fixes the variable used for the RegistryMonitor on a fresh VS
instance.

If the private registry does not have a NatvisDiagnostic section, it
will watch for its creation then delete this watcher.
However when creating the new watcher it would watch on a null section
instead of the new natvis section.

This PR fixes that issue.
@gc46 gc46 merged commit 7ae9e4a into release-cpptools Feb 8, 2023
gc46 pushed a commit that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants