Don't hardcode path to kill in UnixUtilities #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardenGnaw
approved these changes
Nov 14, 2022
gregg-miskelly
approved these changes
Nov 14, 2022
|
Thanks :) Are these build failures relevant? It's a little hard to interpret the output. |
|
@WardenGnaw are the Linux failures just known flakeyness? |
Re-running to double check. I don't recall seeing these failures before. |
|
Different test failed this time. Linux tests are flaky. |
|
Thank you for your contribution @expipiplus1 |
|
Thank you for the quick turnaround on this!
…On Wed, 16 Nov 2022, 4:33 am Andrew Wang, ***@***.***> wrote:
Thank you for your contribution @expipiplus1
<https://github.com/expipiplus1>
—
Reply to this email directly, view it on GitHub
<#1373 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRJXAOGNYXXIVUKABGF6LWIPXSZANCNFSM6AAAAAAR7RQKS4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/vscode-cpptools#10124 (comment)