Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override Newtonsoft.JSON for Component Governance #1323

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

WardenGnaw
Copy link
Member

This PR adds an explcit reference to Newtonsoft.Json for packages the
reference MS.NET.Test.SDK and MS.VS.Shell until they have properly
published packages using Newtonsoft.JSON v13.0.1

@WardenGnaw WardenGnaw self-assigned this Jul 1, 2022
@WardenGnaw WardenGnaw changed the title Override Newtonsoft.JSON for CG Override Newtonsoft.JSON for Component Governance Jul 1, 2022
This PR adds an explcit reference to Newtonsoft.Json for packages the
reference MS.NET.Test.SDK and MS.VS.Shell until they have properly
published packages using Newtonsoft.JSON v13.0.1
Upgrading to 17.2.60629.1
@WardenGnaw WardenGnaw force-pushed the dev/waan/updateNewtonsoft branch from 7ec5fd1 to 90898ca Compare July 5, 2022 22:41
@gregg-miskelly
Copy link
Member

Looks like we should switch the implementation of HandleSetExceptionBreakpointsRequestAsync to the new overload that has a SetExceptionBreakpointsResponse arg.

void HandleSetExceptionBreakpointsRequestAsync(IRequestResponder<SetExceptionBreakpointsArguments, SetExceptionBreakpointsResponse> responder)

@WardenGnaw WardenGnaw merged commit 018e50f into main Jul 6, 2022
@WardenGnaw WardenGnaw deleted the dev/waan/updateNewtonsoft branch August 18, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants