Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS-x64 testing #1177

Merged
merged 7 commits into from
Jul 22, 2021
Merged

Add macOS-x64 testing #1177

merged 7 commits into from
Jul 22, 2021

Conversation

WardenGnaw
Copy link
Member

@WardenGnaw WardenGnaw commented Jul 20, 2021

This PR adds PR tests on macOS-x64

Keeping track of disabled tests at: #1170

@WardenGnaw WardenGnaw force-pushed the dev/waan/enableOsxTesting branch 2 times, most recently from 9f684e5 to d66868a Compare July 20, 2021 18:15
@WardenGnaw WardenGnaw marked this pull request as ready for review July 20, 2021 18:23
@WardenGnaw WardenGnaw self-assigned this Jul 20, 2021
Copy link
Member

@gregg-miskelly gregg-miskelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@WardenGnaw WardenGnaw force-pushed the dev/waan/enableOsxTesting branch from 5d8874d to 1575257 Compare July 21, 2021 18:01
This PR adds PR tests on macOS-x64
@WardenGnaw WardenGnaw force-pushed the dev/waan/enableOsxTesting branch from 1575257 to 935be52 Compare July 21, 2021 18:02
@WardenGnaw
Copy link
Member Author

There seems to be a bug with GetLLDBMIPath, test adapter seems to set miDebuggerPath but it is empty.

Investigating.

@WardenGnaw WardenGnaw merged commit 86bf7c9 into main Jul 22, 2021
@WardenGnaw WardenGnaw deleted the dev/waan/enableOsxTesting branch September 21, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants