Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] move wiki to Read the Docs #945

Merged
merged 44 commits into from
Oct 7, 2017
Merged

[docs] move wiki to Read the Docs #945

merged 44 commits into from
Oct 7, 2017

Conversation

StrikerRUS
Copy link
Collaborator

The main aim of this PR is to move remained wiki pages to docs folder and to Read the Docs in consequence. So all documentation is in one place and wiki could be deleted now.
Also some references have been added to easier navigation through the documentation.
In all README files headings have been refactored to the same type (all capital letters).

Please review Installation-Guide.rst with more attention - I added some sections about GUI compilation with Visual Studio there.
It would be great if someone could help me find out how to made Read the Docs deal with links with anchors and not to break everything.
Also, there is file gcc-tips.Rmd in docs folder on which there are no references. Where it's better to insert the reference to it?
And I want to ask @Laurae2 continue updating LightGBM/docs/Key-Events.md file - it's very useful thing.

GPU Experiments
---------------

Refer to `GPU Performance <./GPU-Performance.rst>`__.
Copy link
Collaborator Author

@StrikerRUS StrikerRUS Sep 29, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've found out that many urls in new doc files (no matter md or rst) couldn't be resolved locally on my machine with make html: they converted to something like LightGBM/docs/_build/html/GPU-Performance.rst or even https://github.com/Microsoft/LightGBM/tree/master/docsInstallation-Guide.md.

Maybe someone knowns WAIDW?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem starts to be more precise. Now links from only rst files are not converted to html.

It was just a typo in md file which was resulted in broken url.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've understood that rst documents are not processed by recommonmark and passed as is. So, my solution is based on js function which allows keep actual links at GitHub (e.g. ./Features.md) and at Read the Docs replace them with .html.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you really need the extension of .rst?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henry0312 Yeah! I decided to convert from md to rst after I found your comment.
Now I have plans (not in this PR) convert all files to rst, so we'll be able to create the documentation without recommonmark which are not compatible with the latest Sphinx (see #958).

Copy link
Collaborator Author

@StrikerRUS StrikerRUS Oct 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I think that ReadTheDocs + GitHub repo is quite enough. I suppose, GitHub Pages is excess thing, GitHub itself renders current rst files rather good (markdown is saved and all cross links are working between files), you may take a look to my branch to see it works.

Yeah, I saw this Sphinx documentation. Unfortunately, such style of links doesn't work at GitHub repo - we need to provide file extensions anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll check your branch.

By the way, when you convert md to rst, you can use Pandoc (although you already used it) like this:

pandoc --columns=200 -f markdown_github -t rst -o hoge.rst hoge.md
(may need to adjust `columns`)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Please also when you will review my branch

Please review Installation-Guide.rst with more attention - I added some sections about GUI compilation with Visual Studio there.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion! Unfortunately, I had problems with Pandoc installation and decided to use online variant with further validation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review Installation-Guide.rst with more attention - I added some sections about GUI compilation with Visual Studio there.

I don't know if the sections are right or wrong because I don't have Windows.
@guolinke, can you help us?

@guolinke guolinke requested a review from henry0312 September 30, 2017 06:16
@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Oct 1, 2017

Since we anyway need _static folder in docs, I decided to store images locally in the repo (they are not heavy) for more independence, because some images were hosted on GitHub, other - on http://www.huan-zhang.com/

@guolinke
Copy link
Collaborator

guolinke commented Oct 2, 2017

@StrikerRUS can you also update the wiki to make them consistent ?
Or put replace the content in the wiki with the link to the new place.

@StrikerRUS
Copy link
Collaborator Author

@guolinke In my opinion, the best thing is do the same as this.

@StrikerRUS
Copy link
Collaborator Author

@Laurae2 Where should I insert the reference to gcc-tips.Rmd file?

* [@wxchan](https://github.com/wxchan) (Python package)
* [@guolinke](https://github.com/guolinke) (C++ code / R-package / Python-package)
* [@Laurae2](https://github.com/Laurae2) (R-package)
* [@wxchan](https://github.com/wxchan) (Python-package)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you also should be here 😄

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😃

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, why you aren't there?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but I will be glad if you add me in this PR :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll definitely add you in this PR.

C++ code / Python-package?

Copy link
Contributor

@henry0312 henry0312 Oct 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just Python-package, please
because I don't understand over half of cpp codes :p
(though I can read and wrire c++)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK 😄

@@ -0,0 +1,4 @@
window.onload = function() {
Copy link
Contributor

@henry0312 henry0312 Oct 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you check the rst_links_fix.js to work on built documentations (or Read The Doc) ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it locally on my machine - all seems to be OK.
On Travis it's done by emulation of this js function.

Copy link
Collaborator Author

@StrikerRUS StrikerRUS Oct 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's jQuery, it should work with all browsers. In theory...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay.

In theory...

yeah, in theory 😅

@henry0312
Copy link
Contributor

Almost all of the changes look good to me.
Please fix conflict.

@StrikerRUS
Copy link
Collaborator Author

Sorry, I'm away from my computer. I'll ping you after update.
Nevertheless, we are waiting the answer about Installation Tutorial on Windows.

@guolinke
Copy link
Collaborator

guolinke commented Oct 7, 2017

@Laurae2 can you answer StrikerRUS's question ?

@Laurae2
Copy link
Contributor

Laurae2 commented Oct 7, 2017

@Laurae2 Where should I insert the reference to gcc-tips.Rmd file?

What do you mean by "where"? (I'm 2 weeks behind on this repo so I'm not sure what happened)

Nevertheless, we are waiting the answer about Installation Tutorial on Windows.

Which one?

And I want to ask @Laurae2 continue updating LightGBM/docs/Key-Events.md file - it's very useful thing.

Missing time here.

@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Oct 7, 2017

@Laurae2

What do you mean by "where"? (I'm 2 weeks behind on this repo so I'm not sure what happened)

Now this document has no references at itself from other ones. I want to fix this situation. Does it document is relevant to only R-users?

Nevertheless, we are waiting the answer about Installation Tutorial on Windows.
Which one?

This question is for @guolinke: #945 (comment)

@Laurae2
Copy link
Contributor

Laurae2 commented Oct 7, 2017

@StrikerRUS It is relevant for any user using gcc and not wanting to use the default optimization flags (such as using precompiled packages for different Intel generation with different extra instruction sets), especially for those using linux.

@StrikerRUS
Copy link
Collaborator Author

@Laurae2 Got it, thank you!


3. Go to ``LightGBM-master/windows`` folder.

4. Open ``LightGBM.sln`` file with Visual Studio, choose ``Release`` configuration and click ``BUILD-> Build Solution (Ctrl+Shift+B)``.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to select X64 as well ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no another choice neither at start windows, nor in project settings:

image
image

@guolinke guolinke merged commit 6d34fb8 into microsoft:master Oct 7, 2017
@StrikerRUS
Copy link
Collaborator Author

@guolinke I replaced wiki pages with corresponding links to Read the Docs.

@StrikerRUS StrikerRUS deleted the readthedocs branch October 7, 2017 20:04
guolinke pushed a commit that referenced this pull request Oct 9, 2017
* fixed Python-API references

* moved Features section to ReadTheDocs

* fixed index of ReadTheDocs

* moved Experiments section to ReadTheDocs

* fixed capital letter

* fixed citing

* moved Parallel Learning section to ReadTheDocs

* fixed markdown

* fixed Python-API

* fixed link to Quick-Start

* fixed gpu docker README

* moved Installation Guide from wiki to ReadTheDocs

* removed references to wiki

* fixed capital letters in headings

* hotfixes

* fixed non-Unicode symbols and reference to Python API

* fixed citing references

* fixed links in .md files

* fixed links in .rst files

* store images locally in the repo

* fixed missed word

* fixed indent in Experiments.rst

* fixed 'Duplicate implicit target name' message which is successfully
resolved by adding anchors

* less verbose

* prevented maito: ref creation

* fixed indents

* fixed 404

* fixed 403

* fixed 301

* fixed fake anchors

* fixed file extentions

* fixed Sphinx warnings

* added StrikerRUS profile link to FAQ

* added henry0312 profile link to FAQ
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants