-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] move wiki to Read the Docs #945
Conversation
GPU Experiments | ||
--------------- | ||
|
||
Refer to `GPU Performance <./GPU-Performance.rst>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've found out that many urls in new doc files (no matter md
or rst
) couldn't be resolved locally on my machine with make html
: they converted to something like LightGBM/docs/_build/html/GPU-Performance.rst
or even https://github.com/Microsoft/LightGBM/tree/master/docsInstallation-Guide.md
.
Maybe someone knowns WAIDW?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem starts to be more precise. Now links from only rst
files are not converted to html
.
It was just a typo in md
file which was resulted in broken url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've understood that rst
documents are not processed by recommonmark and passed as is. So, my solution is based on js function which allows keep actual links at GitHub (e.g. ./Features.md
) and at Read the Docs replace them with .html
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you really need the extension of .rst
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henry0312 Yeah! I decided to convert from md
to rst
after I found your comment.
Now I have plans (not in this PR) convert all files to rst
, so we'll be able to create the documentation without recommonmark which are not compatible with the latest Sphinx (see #958).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I think that ReadTheDocs + GitHub repo is quite enough. I suppose, GitHub Pages is excess thing, GitHub itself renders current rst
files rather good (markdown is saved and all cross links are working between files), you may take a look to my branch to see it works.
Yeah, I saw this Sphinx documentation. Unfortunately, such style of links doesn't work at GitHub repo - we need to provide file extensions anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I'll check your branch.
By the way, when you convert md
to rst
, you can use Pandoc (although you already used it) like this:
pandoc --columns=200 -f markdown_github -t rst -o hoge.rst hoge.md
(may need to adjust `columns`)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Please also when you will review my branch
Please review Installation-Guide.rst with more attention - I added some sections about GUI compilation with Visual Studio there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your suggestion! Unfortunately, I had problems with Pandoc installation and decided to use online variant with further validation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review Installation-Guide.rst with more attention - I added some sections about GUI compilation with Visual Studio there.
I don't know if the sections are right or wrong because I don't have Windows.
@guolinke, can you help us?
Since we anyway need |
@StrikerRUS can you also update the wiki to make them consistent ? |
@Laurae2 Where should I insert the reference to |
* [@wxchan](https://github.com/wxchan) (Python package) | ||
* [@guolinke](https://github.com/guolinke) (C++ code / R-package / Python-package) | ||
* [@Laurae2](https://github.com/Laurae2) (R-package) | ||
* [@wxchan](https://github.com/wxchan) (Python-package) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you also should be here 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 😃
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, why you aren't there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but I will be glad if you add me in this PR :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I'll definitely add you in this PR.
C++ code / Python-package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just Python-package, please
because I don't understand over half of cpp codes :p
(though I can read and wrire c++)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK 😄
@@ -0,0 +1,4 @@ | |||
window.onload = function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you check the rst_links_fix.js
to work on built documentations (or Read The Doc) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked it locally on my machine - all seems to be OK.
On Travis it's done by emulation of this js function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's jQuery, it should work with all browsers. In theory...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay.
In theory...
yeah, in theory 😅
Almost all of the changes look good to me. |
Sorry, I'm away from my computer. I'll ping you after update. |
@Laurae2 can you answer StrikerRUS's question ? |
What do you mean by "where"? (I'm 2 weeks behind on this repo so I'm not sure what happened)
Which one?
Missing time here. |
Now this document has no references at itself from other ones. I want to fix this situation. Does it document is relevant to only R-users?
This question is for @guolinke: #945 (comment) |
@StrikerRUS It is relevant for any user using gcc and not wanting to use the default optimization flags (such as using precompiled packages for different Intel generation with different extra instruction sets), especially for those using linux. |
@Laurae2 Got it, thank you! |
|
||
3. Go to ``LightGBM-master/windows`` folder. | ||
|
||
4. Open ``LightGBM.sln`` file with Visual Studio, choose ``Release`` configuration and click ``BUILD-> Build Solution (Ctrl+Shift+B)``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to select X64
as well ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guolinke I replaced wiki pages with corresponding links to Read the Docs. |
* fixed Python-API references * moved Features section to ReadTheDocs * fixed index of ReadTheDocs * moved Experiments section to ReadTheDocs * fixed capital letter * fixed citing * moved Parallel Learning section to ReadTheDocs * fixed markdown * fixed Python-API * fixed link to Quick-Start * fixed gpu docker README * moved Installation Guide from wiki to ReadTheDocs * removed references to wiki * fixed capital letters in headings * hotfixes * fixed non-Unicode symbols and reference to Python API * fixed citing references * fixed links in .md files * fixed links in .rst files * store images locally in the repo * fixed missed word * fixed indent in Experiments.rst * fixed 'Duplicate implicit target name' message which is successfully resolved by adding anchors * less verbose * prevented maito: ref creation * fixed indents * fixed 404 * fixed 403 * fixed 301 * fixed fake anchors * fixed file extentions * fixed Sphinx warnings * added StrikerRUS profile link to FAQ * added henry0312 profile link to FAQ
The main aim of this PR is to move remained wiki pages to
docs
folder and to Read the Docs in consequence. So all documentation is in one place and wiki could be deleted now.Also some references have been added to easier navigation through the documentation.
In all README files headings have been refactored to the same type (all capital letters).
Please review
Installation-Guide.rst
with more attention - I added some sections about GUI compilation with Visual Studio there.It would be great if someone could help me find out how to made Read the Docs deal with links with anchors and not to break everything.
Also, there is file
gcc-tips.Rmd
indocs
folder on which there are no references. Where it's better to insert the reference to it?And I want to ask @Laurae2 continue updating
LightGBM/docs/Key-Events.md
file - it's very useful thing.