-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] fix MSVC warning about builds in temp directory #6573
Conversation
Checked all Windows builds: no warning. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I agree, this should have always been in test_windows.ps1
and not specific to the R package.
I've restarted the failing CI jobs for you.
I also edited the title to "MSVC" instead of "MSVS". I think it's more common to use "MSVC" when referring to the compiler and "MSVS" when referring to the IDE. That is typically what we've done here in LightGBM. But please change it back if you disagree, I don't think the distinction is too important.
Hmm, some builds failed with the following error:
I guess it can be somehow related to persistent mounts across builds (#6465, #6416)... Will investigate this. |
Wait! They are all Linux jobs, not Windows ones... 🤔 |
Ok, found the root cause! Jobs are failing because lightgbm is installed from PyPI not from source there. |
Please check one more time - I added initial cleanup for the directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
Hopefully THIS is the last "things left behind in the build directory" issue we have 😂
Currently this fix is applied only to R-package builds.
This PR proposes adding this fix to all Windows builds.
https://ci.appveyor.com/project/guolinke/lightgbm/builds/50283647/job/bo2wb8ejurn0b0k6#L798