Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [docs] update some docs and CI dependencies #6346

Merged
merged 10 commits into from
Mar 19, 2024
Merged

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Feb 28, 2024

Proposes updating the following dependencies to their latest versions:

Benefits of these changes

  • faster conda environment solves = faster builds
  • extends further into the future the time til we have to upgrade these language versions on readthedocs again

Notes for Reviewers

Even though the latest release of sphinx is the 7.x series, I'm proposing using sphinx>=6.0 because LightGBM'ss docs rely on breathe, and as of this writing the breathe conda-forge package has a ceiling of breathe<7.0.

Despite that ceiling not being present for wheels on PyPI:

# this happily installs breather 4.35 and sphinx 7.2.6 together
docker run \
  --rm \
  -it python:3.10 \
   /bin/bash -c "pip install 'breathe>=4.35' 'sphinx>7.0'"

@jameslamb jameslamb marked this pull request as ready for review March 4, 2024 02:41
Copy link
Collaborator

@borchero borchero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jameslamb jameslamb merged commit 6a1ec44 into master Mar 19, 2024
41 of 42 checks passed
@jameslamb jameslamb deleted the ci/conda-envs branch March 19, 2024 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants