WIP: [ci] [python-package] remove unused mypy type-ignore comments #5857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #3867.
As more of the library's code gets type annotations, as errors in those annotations are fixed, and as
mypy
itself is improved, some# type: ignore
comments used to suppressmypy
errors can become irrelevant.This PR proposes running
mypy
with--warn-unused-ignores
, which will causemypy
to fail if unnecessary# type: ignore
comments are used.This is useful because
# type: ignore
comments can sometimes causemypy
to stop checking down a code path, and removing unnecessary ones therefore improves the likelihood that problems can be detected bymypy
.This PR also fixes the following errors introduced by that check.