Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python-package] prefix c_int_array and c_float_array with _ #5614

Merged
merged 1 commit into from
Dec 8, 2022
Merged

[python-package] prefix c_int_array and c_float_array with _ #5614

merged 1 commit into from
Dec 8, 2022

Conversation

OmarManzoor
Copy link
Contributor

Contributes to #5313

@jameslamb
Copy link
Collaborator

closing and re-opening to try to get the warning from the CLA bot to go away (sorry @OmarManzoor ).

@jameslamb jameslamb closed this Dec 6, 2022
@jameslamb jameslamb reopened this Dec 6, 2022
@jameslamb
Copy link
Collaborator

@OmarManzoor , can you please add a comment exactly like this one?

#5545 (comment)

I'm so sorry about that. We don't control the CLA bot (it is something Microsoft-wide, configured by people at Microsoft who don't work on this repo).

I hope that after you do this, you won't have to again.

jameslamb
jameslamb approved these changes Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for doing this!

@OmarManzoor
Copy link
Contributor Author

@microsoft-github-policy-service agree

@jameslamb jameslamb mentioned this pull request Dec 6, 2022
Merged
@jameslamb
Copy link
Collaborator

Thanks @OmarManzoor ! I'll manually re-run the failing CI job (not related to this PR's changes) and then merge this.

@jameslamb jameslamb closed this Dec 7, 2022
@jameslamb jameslamb reopened this Dec 7, 2022
@jameslamb jameslamb merged commit 6fa4673 into microsoft:master Dec 8, 2022
@OmarManzoor OmarManzoor deleted the basic-c_int_array_and_c_float_array branch December 8, 2022 06:44
@jameslamb jameslamb mentioned this pull request Dec 30, 2022
Closed
42 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@StrikerRUS StrikerRUS Awaiting requested review from StrikerRUS StrikerRUS is a code owner

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

@jmoralez jmoralez Awaiting requested review from jmoralez jmoralez is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OmarManzoor @jameslamb