Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests][python-package] remove remaining tests using load_boston (fixes #4793) #5581

Merged
merged 6 commits into from
Dec 13, 2022
Merged

[tests][python-package] remove remaining tests using load_boston (fixes #4793) #5581

merged 6 commits into from
Dec 13, 2022

Conversation

jmoralez
Copy link
Collaborator

@jmoralez jmoralez commented Nov 10, 2022 •
edited
Loading

Fixes #4793.

@jmoralez jmoralez changed the title [tests][python-package] remove remaining tests using load_boston [tests][python-package] remove remaining tests using load_boston (fixes #4793) Dec 8, 2022
@jmoralez jmoralez marked this pull request as ready for review December 8, 2022 02:58
jameslamb
jameslamb approved these changes Dec 8, 2022
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this!!! Looks good to me. I trust that the thresholds you chose for the various metrics was close to the metrics you observed, and really appreciate you merging the MAPE tests with pytest.parametrize().

@jameslamb jameslamb mentioned this pull request Dec 13, 2022
Closed
@jameslamb
Copy link
Collaborator

I'm going to merge this to unblock CI, now that scikit-learn 1.2 is out.

Thanks again @jmoralez !

cc @shiyu1994

@jameslamb jameslamb merged commit 9afd8b9 into master Dec 13, 2022
@jameslamb jameslamb deleted the remove-boston branch December 13, 2022 05:22
@jameslamb jameslamb mentioned this pull request Dec 13, 2022
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@StrikerRUS StrikerRUS Awaiting requested review from StrikerRUS StrikerRUS is a code owner

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[tests][python-package] Modify tests using boston housing dataset
2 participants
@jmoralez @jameslamb