-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[python-package] prefix is_numpy_1d_array with _ #5520
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to LightGBM!
The CI failures are not something you need to worry about. We are currently working through some instability in the project's CI (see #5510) and will come back to merge this after those are resolved. Sorry for the inconvenience.
Thanks! I merged it 👍 |
Thanks again for this! @Madnex in the future, I strongly recommend that you create a branch on your fork, instead of committing directly to Now that I've merged this, your If you want to keep contributing (and I hope you do!), the easiest way to fix that is probably just to:
git clone --recursive https://github.com/Madnex/LightGBM.git
cd LightGBM
git checkout -b some-feature 👋 cheers and have a good weekend! |
Thanks for the tipp @jameslamb ! Will do and prepare the next PR :) |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Contributes to #5313