Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[python-package] make a shallow copy when replacing categorical features with codes (fixes #4596) #5225

Merged
merged 1 commit into from
May 22, 2022
Merged

[python-package] make a shallow copy when replacing categorical features with codes (fixes #4596) #5225

merged 1 commit into from
May 22, 2022

Conversation

jmoralez
Copy link
Collaborator

Fixes #4596.

guolinke
guolinke approved these changes May 21, 2022
View reviewed changes
Copy link
Collaborator

@guolinke guolinke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

jameslamb
jameslamb approved these changes May 21, 2022
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice tests! Thanks for the excellent ork on this, especially using profiling to prove this works.

StrikerRUS
StrikerRUS approved these changes May 21, 2022
View reviewed changes
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@guolinke guolinke merged commit c000b8c into master May 22, 2022
@guolinke guolinke deleted the shallow-copy-df branch May 22, 2022 01:28
@jmoralez jmoralez mentioned this pull request May 30, 2022
Merged
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
Closed
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@guolinke guolinke guolinke approved these changes

@StrikerRUS StrikerRUS StrikerRUS approved these changes

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

Assignees
No one assigned
Labels
efficiency
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid dataframe deep copy while creating dataset
4 participants
@jmoralez @jameslamb @guolinke @StrikerRUS