Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add avatar to Yu Shi in R docs #4690

Merged
merged 1 commit into from
Oct 18, 2021
Merged

[docs] Add avatar to Yu Shi in R docs #4690

merged 1 commit into from
Oct 18, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Right now the first author and maintainer of R-package has no avatar:

image

@StrikerRUS StrikerRUS added the doc label Oct 17, 2021
@StrikerRUS StrikerRUS requested a review from jameslamb as a code owner October 17, 2021 18:42
@StrikerRUS StrikerRUS requested a review from shiyu1994 October 17, 2021 18:43
@StrikerRUS
Copy link
Collaborator Author

StrikerRUS commented Oct 17, 2021 •
edited
Loading

Also, I added new item

Change development.mode from unreleased to release in pkgdown config file.

in our release TODO checklist.

unreleased:

image

release:

image

Refer to https://pkgdown.r-lib.org/reference/build_site.html#development-mode
Related: #4236

jameslamb
jameslamb approved these changes Oct 18, 2021
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah agree, thanks for looking into the R docs!

@jameslamb jameslamb merged commit fddff1a into master Oct 18, 2021
@jameslamb jameslamb deleted the r_docs_avatar branch October 18, 2021 02:28
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

@shiyu1994 shiyu1994 Awaiting requested review from shiyu1994 shiyu1994 is a code owner

Assignees
No one assigned
Labels
doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StrikerRUS @jameslamb