Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] use commandArgs instead of hardcoded stuff in the installation script #2441

Closed
StrikerRUS opened this issue Sep 24, 2019 · 3 comments · Fixed by #3574
Closed

Comments

@StrikerRUS
Copy link
Collaborator

StrikerRUS commented Sep 24, 2019

Today, installing the R package with CMake like this:

Rscript build_r.R

Might require you to manually change some flags in R-package/install.libs.R.

# User options
use_precompile <- FALSE
use_gpu <- FALSE
use_mingw <- FALSE

Refer to #2164 (comment).

To close this issue, expose those flags as command-line flags so users can do something like this:

Rscript build_r.R --use-gpu
@StrikerRUS
Copy link
Collaborator Author

Closed in favor of being in #2302. We decided to keep all feature requests in one place.

Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

@jameslamb
Copy link
Collaborator

if you're reading this and interested in contributing this feature, please comment here. Feel free to @ me with questions

@jameslamb jameslamb reopened this Nov 7, 2020
@jameslamb jameslamb self-assigned this Nov 27, 2020
StrikerRUS added a commit that referenced this issue Nov 29, 2020
) (#3574)

* [R-package] Use command-line args to customize CMake builds (fixes #2441)

* Apply suggestions from code review

Co-authored-by: Nikita Titov <[email protected]>

Co-authored-by: Nikita Titov <[email protected]>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants