Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

DOC: Improve setup for running the HelloWorld model in AzureML #693

Merged
merged 7 commits into from
Mar 15, 2022

Conversation

ant0nsc
Copy link
Contributor

@ant0nsc ant0nsc commented Mar 9, 2022

Please follow the guidelines for PRs contained here. Checklist:

  • Ensure that your PR is small, and implements one change.
  • Add unit tests for all functions that you introduced or modified.
  • Run PyCharm's code cleanup tools on your Python files.
  • Link the correct GitHub issue for tracking.
  • Update the Changelog file: Describe your change in terms of
    Added/Changed/Removed/... in the "Upcoming" section.
  • When merging your PR, replace the default merge message with a description of your PR,
    and if needed a motivation why that change was required.

@ant0nsc ant0nsc requested review from mebristo and fepegar March 10, 2022 09:20
fepegar
fepegar previously approved these changes Mar 10, 2022
Copy link
Contributor

@fepegar fepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a little suggestion for a URL, nothing critical.

I see you've installed a Markdown linter :D Maybe we should fix all the documents in an isolated PR, it'll be hard to see the changes otherwise.

docs/hello_world_model.md Outdated Show resolved Hide resolved
docs/hello_world_model.md Outdated Show resolved Hide resolved
mebristo
mebristo previously approved these changes Mar 10, 2022
@ant0nsc ant0nsc dismissed stale reviews from mebristo and fepegar via 0d7d58b March 11, 2022 15:06
@ant0nsc ant0nsc requested review from fepegar and mebristo March 11, 2022 15:06
@ant0nsc ant0nsc enabled auto-merge (squash) March 11, 2022 15:06
@ant0nsc ant0nsc changed the title Improve setup for running the HelloWorld model in AzureML DOC: Improve setup for running the HelloWorld model in AzureML Mar 11, 2022
docs/hello_world_model.md Outdated Show resolved Hide resolved
docs/hello_world_model.md Outdated Show resolved Hide resolved
@ant0nsc ant0nsc requested a review from fepegar March 15, 2022 13:59
@ant0nsc ant0nsc merged commit f0d2337 into main Mar 15, 2022
@ant0nsc ant0nsc deleted the antonsc/hello_world_doc branch March 15, 2022 14:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants