Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Split validation and test infer config #502

Merged
merged 33 commits into from
Jul 5, 2021
Merged

Conversation

JonathanTripp
Copy link
Contributor

@JonathanTripp JonathanTripp commented Jun 22, 2021

Add more flags to control when to run inference to give a total of 6. One for each of test/train/validate, for normal runs and ensemble runs.

@pep8speaks
Copy link

pep8speaks commented Jun 28, 2021

Hello @JonathanTripp! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 22:80: E501 line too long (83 > 79 characters)
Line 327:80: E501 line too long (84 > 79 characters)

Line 462:80: E501 line too long (88 > 79 characters)
Line 479:80: E501 line too long (108 > 79 characters)
Line 482:80: E501 line too long (109 > 79 characters)
Line 483:80: E501 line too long (110 > 79 characters)
Line 487:80: E501 line too long (83 > 79 characters)
Line 490:80: E501 line too long (93 > 79 characters)

Line 204:80: E501 line too long (104 > 79 characters)
Line 207:80: E501 line too long (106 > 79 characters)
Line 210:80: E501 line too long (100 > 79 characters)
Line 213:80: E501 line too long (117 > 79 characters)
Line 216:80: E501 line too long (115 > 79 characters)
Line 219:80: E501 line too long (109 > 79 characters)
Line 267:80: E501 line too long (114 > 79 characters)
Line 269:80: E501 line too long (93 > 79 characters)
Line 271:80: E501 line too long (101 > 79 characters)
Line 273:80: E501 line too long (100 > 79 characters)
Line 275:80: E501 line too long (104 > 79 characters)
Line 281:80: E501 line too long (119 > 79 characters)
Line 283:80: E501 line too long (118 > 79 characters)
Line 285:80: E501 line too long (122 > 79 characters)

Line 439:80: E501 line too long (111 > 79 characters)
Line 441:80: E501 line too long (110 > 79 characters)
Line 443:80: E501 line too long (112 > 79 characters)
Line 492:80: E501 line too long (82 > 79 characters)
Line 759:80: E501 line too long (85 > 79 characters)
Line 760:80: E501 line too long (110 > 79 characters)
Line 769:80: E501 line too long (85 > 79 characters)

Line 16:80: E501 line too long (84 > 79 characters)
Line 30:80: E501 line too long (126 > 79 characters)
Line 32:80: E501 line too long (112 > 79 characters)
Line 46:80: E501 line too long (87 > 79 characters)
Line 47:80: E501 line too long (100 > 79 characters)
Line 50:80: E501 line too long (83 > 79 characters)
Line 53:80: E501 line too long (93 > 79 characters)
Line 60:80: E501 line too long (122 > 79 characters)
Line 61:80: E501 line too long (95 > 79 characters)
Line 64:80: E501 line too long (92 > 79 characters)
Line 67:80: E501 line too long (94 > 79 characters)
Line 71:80: E501 line too long (89 > 79 characters)
Line 72:80: E501 line too long (98 > 79 characters)
Line 74:80: E501 line too long (93 > 79 characters)
Line 94:80: E501 line too long (84 > 79 characters)
Line 123:80: E501 line too long (88 > 79 characters)
Line 124:80: E501 line too long (87 > 79 characters)
Line 125:80: E501 line too long (85 > 79 characters)
Line 126:80: E501 line too long (95 > 79 characters)
Line 161:80: E501 line too long (90 > 79 characters)
Line 162:80: E501 line too long (93 > 79 characters)
Line 163:80: E501 line too long (90 > 79 characters)
Line 164:80: E501 line too long (124 > 79 characters)
Line 173:80: E501 line too long (81 > 79 characters)
Line 203:80: E501 line too long (94 > 79 characters)
Line 208:80: E501 line too long (86 > 79 characters)
Line 209:80: E501 line too long (94 > 79 characters)

Comment last updated at 2021-06-28 19:32:00 UTC

@JonathanTripp JonathanTripp marked this pull request as ready for review June 29, 2021 11:45
InnerEye/ML/deep_learning_config.py Outdated Show resolved Hide resolved
InnerEye/ML/deep_learning_config.py Outdated Show resolved Hide resolved
InnerEye/ML/run_ml.py Outdated Show resolved Hide resolved
InnerEye/ML/run_ml.py Outdated Show resolved Hide resolved
azure-pipelines/build-pr.yml Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
ant0nsc
ant0nsc previously approved these changes Jun 30, 2021
dumbledad
dumbledad previously approved these changes Jun 30, 2021

```
--inference_on_train_set=True or False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say here what the defaults are?

@JonathanTripp JonathanTripp dismissed stale reviews from dumbledad and ant0nsc via a6e3961 July 2, 2021 13:20
@JonathanTripp JonathanTripp enabled auto-merge (squash) July 5, 2021 15:23
@JonathanTripp JonathanTripp merged commit cab68cc into main Jul 5, 2021
@JonathanTripp JonathanTripp deleted the jontri/ensemble_infer branch July 5, 2021 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Building segmentation ensemble models is slow because of full image inference in the child runs
4 participants