This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
Migrate to Pytorch Lightning #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use_sync_dist
ozan-oktay
reviewed
Jan 27, 2021
Shruthi42
reviewed
Jan 27, 2021
ozan-oktay
reviewed
Jan 27, 2021
Shruthi42
reviewed
Jan 28, 2021
Shruthi42
reviewed
Jan 28, 2021
| @@ -61,7 +60,6 @@ def __init__(self, | |||
| encoder_dimensionality_reduction_factor: float = 0.8, | |||
| aggregation_type: AggregationType = AggregationType.Average, | |||
| scan_size: Optional[TupleInt3] = None, | |||
| use_mixed_precision: bool = True, | |||
There was a problem hiding this comment.
Why do we remove use_mixed_precision only for this model?
There was a problem hiding this comment.
All of the mixed precision magic is now wrapped into PL, it should not be done explicitly anymore
There was a problem hiding this comment.
It looks like use_mixed_precision is still used in MultiSegmentationEncoder and (trivially) in the tests here.
ozan-oktay
reviewed
Jan 28, 2021
ozan-oktay
reviewed
Jan 28, 2021
Shruthi42
reviewed
Jan 28, 2021
Shruthi42
previously approved these changes
Jan 28, 2021
javier-alvarez
approved these changes
Jan 28, 2021
Shruthi42
approved these changes
Jan 28, 2021
This was referenced Jan 29, 2021
This was
linked to
issues
Jan 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps out all of the previously hand-written training routines, and switches them to PyTorch Lightning.