Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL Server connection with removing username/secret #661

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

olivershen-wow
Copy link
Contributor

@olivershen-wow olivershen-wow commented Jul 10, 2024

Description

Enable Managed Identity authentication on Azure by doing the following:

  • Updated DB Connection String
  • Move redundant username/password from basic env yml to specific envs

Linked GitHub issue ID:

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.
Tested locally with local account, allocating the same permissions in DB and run the app without error.

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...

@olivershen-wow olivershen-wow requested a review from zhou9584 as a code owner July 10, 2024 10:30
@olivershen-wow olivershen-wow enabled auto-merge (squash) July 10, 2024 10:31
zhou9584
zhou9584 previously approved these changes Jul 15, 2024
zhou9584
zhou9584 previously approved these changes Jul 15, 2024
@olivershen-wow olivershen-wow disabled auto-merge July 15, 2024 10:10
@olivershen-wow olivershen-wow merged commit c6988d8 into main Jul 15, 2024
5 checks passed
@olivershen-wow olivershen-wow deleted the user/lsh/fix-SQL-DB-secret branch July 15, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants