Fix Event Typing Error Due to Too Many Overloads #5908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd optimistically increased the number of event overloads, but not consumed it. As part of bumping all packages it turns out we've hit an intrinsic typescript limit for recursive types, which was leading to “TS2589: Type instantiation is excessively deep and possibly infinite” . This change reduces the number of overloads to the number which works, and is still more than we currently use anywhere.
There are few typescript issues this could be related to:
microsoft/TypeScript#34933
microsoft/TypeScript#41406