Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Assert Shortcodes #5619

Merged
merged 10 commits into from
Mar 25, 2021
Merged

Add Assert Shortcodes #5619

merged 10 commits into from
Mar 25, 2021

Conversation

anthony-murphy
Copy link
Contributor

@anthony-murphy anthony-murphy commented Mar 22, 2021 •
edited
Loading

Now that the automation is coming together, and this change will apply the first set of shortcodes

related to #5409 #5529 #5552

@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Mar 22, 2021 •
edited
Loading

⯆ @fluidframework/base-host: -2.18 KB
Metric NameBaseline SizeCompare SizeSize Diff
main.js 182.17 KB 179.99 KB ⯆ -2.18 KB
Total Size 182.17 KB 179.99 KB ⯆ -2.18 KB
⯆ @fluid-example/bundle-size-tests: -17.49 KB
Metric NameBaseline SizeCompare SizeSize Diff
container.js 209.8 KB 201.54 KB ⯆ -8.25 KB
map.js 49.89 KB 49.11 KB ⯆ -796 Bytes
matrix.js 147.62 KB 143.42 KB ⯆ -4.2 KB
odspDriver.js 202.09 KB 201.22 KB ⯆ -891 Bytes
sharedString.js 161.54 KB 158.14 KB ⯆ -3.39 KB
Total Size 770.94 KB 753.45 KB ⯆ -17.49 KB

Baseline commit: 4006ac8

Generated by 🚫 dangerJS against ae5e155

@anthony-murphy
Copy link
Contributor Author

@jatgarg i'd like this to make the 0.37 release

curtisman
curtisman approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@curtisman curtisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions github-actions bot requested a review from curtisman March 25, 2021 17:47
@anthony-murphy anthony-murphy merged commit 0b4889b into microsoft:main Mar 25, 2021
@anthony-murphy anthony-murphy deleted the assert-short-code branch March 25, 2021 18:03
@ksbrar ksbrar mentioned this pull request Apr 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladsud vladsud Awaiting requested review from vladsud

@tanviraumi tanviraumi Awaiting requested review from tanviraumi

@ChumpChief ChumpChief Awaiting requested review from ChumpChief

@jatgarg jatgarg Awaiting requested review from jatgarg

@znewton znewton Awaiting requested review from znewton

@markfields markfields Awaiting requested review from markfields

@curtisman curtisman Awaiting requested review from curtisman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anthony-murphy @msfluid-bot @curtisman