Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(client): fix Signals test #22559

Merged
merged 1 commit into from
Sep 18, 2024
Merged

test(client): fix Signals test #22559

merged 1 commit into from
Sep 18, 2024

Conversation

jason-ha
Copy link
Contributor

to keep test failures from closing connection and sending a telemetry report

Keep test assertions on the side and re-raise outside of signal processing.

Additionally, reorganize code to reduce duplication and tidy some error messages and constant values.

to keep test failures from closing connection and sending a telemetry report

Keep test assertions on the side and re-raise outside of signal processing.

Additionally, reorganize code to reduce duplication and tidy some error messages and constant values.
@github-actions github-actions bot added area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch labels Sep 18, 2024
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +245 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 460.43 KB 460.47 KB +35 Bytes
azureClient.js 559.03 KB 559.08 KB +49 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 261.68 KB 261.69 KB +14 Bytes
fluidFramework.js 402.58 KB 402.6 KB +14 Bytes
loader.js 134.17 KB 134.19 KB +14 Bytes
map.js 42.43 KB 42.44 KB +7 Bytes
matrix.js 145.87 KB 145.88 KB +7 Bytes
odspClient.js 526.18 KB 526.23 KB +49 Bytes
odspDriver.js 97.8 KB 97.82 KB +21 Bytes
odspPrefetchSnapshot.js 42.76 KB 42.78 KB +14 Bytes
sharedString.js 162.83 KB 162.84 KB +7 Bytes
sharedTree.js 393.05 KB 393.05 KB +7 Bytes
Total Size 3.3 MB 3.3 MB +245 Bytes

Baseline commit: 1d2fe12

Generated by 🚫 dangerJS against ef6902a

@jason-ha jason-ha merged commit 42b4dce into main Sep 18, 2024
30 checks passed
@jason-ha jason-ha deleted the test-keep-errors-from-client branch September 18, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants