Automation: main-next integrate #18699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This TODO has been resolved and is no longer relevant.
## Description Converts some inline comments to JSDoc comments, adds more elaboration on the semantics of localSeq. --------- Co-authored-by: Abram Sanderson <[email protected]> Co-authored-by: jzaffiro <[email protected]>
## Description Converts OptionalField's format to refer to child node changes using the RegisterId that the node occupies in the input context of the change rather than the output context. This makes it consistent with the delta format (which is not necessary, but convenient) and generally simplifies some of the ChangeRebaser logic. ## Breaking Changes This is a breaking change to OptionalField's format semantics, since child changes refer to the node occupied by a register in the input context rather than the output context. I was mildly disturbed that this didn't already result in snapshot test failure, so I added a snapshot scenario which exercises most of optional-field's interesting scenarios from the edit manager perspective (this snapshot test would have been broken had it existed before this change). As usual, no back-compat attempt was made as the format is not yet stable. --------- Co-authored-by: Abram Sanderson <[email protected]>
…ss to be alpha (#18608) This PR is preparation for changing the tagging on the ContainerRuntime class to be alpha. All these types were automatically identified as transitive dependency of the ContainerRuntime class which will be made alpha in a later review. We will stage these commits and invite review, however review items will generally be added to the backlog as future items, as these type updates are necessary for the current state of the code base. Co-authored-by: Tony Murphy <[email protected]>
… be alpha (#18610) This PR updates tagging so the ContainerRuntime class can be alpha. All these types were automatically identified as transitive dependency of the ContainerRuntime class is made alpha. We will stage these commits and invite review, however review items will generally be added to the backlog as future items, as these type updates are necessary for the current state of the code base. Co-authored-by: Tony Murphy <[email protected]>
github-actions
bot
added
community-contribution
base: next
sonalideshpandemsft
force-pushed
the
main-next-bb9258a
branch
from
e55585c to
bb9258a
Compare
⯆ @fluid-example/bundle-size-tests: -116 Bytes
Baseline commit: 440bf1f |
sonalideshpandemsft
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main-next integrate PR
DO NOT MERGE THIS PR USING THE GITHUB UI.
The aim of this pull request is to sync main and next branch. If this PR is assigned to you, you need to do the following:
git commit --amend -m "Automation: main-next integrate"git push --force-with-leaseOnce CI passes and the PR is ready to merge, add the "msftbot: merge-next" label to the PR and one of the people with merge permissions will merge it in.