Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag common types necessary for the Loader class to be alpha #18605

Merged

Conversation

anthony-murphy
Copy link
Contributor

This PR is preparation for changing the tagging on the Loader class to alpha. All these types were automatically identified a transitive dependency of the Loader class which will be made alpha in a later review.

We will stage these commits the invite review, however review items will generally be added to the backlog as future items, as these type updates are necessary for the current state of the code base.

@anthony-murphy anthony-murphy requested a review from a team as a code owner December 2, 2023 00:07
@github-actions github-actions bot added public api change Changes to a public API base: main PRs targeted against main branch labels Dec 2, 2023
@anthony-murphy anthony-murphy added the fluid2alpha Tag to track discussions related to the Fluid 2.0 release label Dec 2, 2023
@anthony-murphy anthony-murphy enabled auto-merge (squash) December 2, 2023 00:21
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +14 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 450.83 KB 450.83 KB +2 Bytes
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 241.14 KB 241.14 KB No change
loader.js 167.41 KB 167.41 KB +2 Bytes
map.js 48.05 KB 48.05 KB +2 Bytes
matrix.js 141.84 KB 141.84 KB +2 Bytes
odspDriver.js 90.35 KB 90.36 KB +2 Bytes
odspPrefetchSnapshot.js 41.82 KB 41.82 KB +2 Bytes
sharedString.js 162.77 KB 162.77 KB No change
sharedTree2.js 290.35 KB 290.35 KB No change
Total Size 1.75 MB 1.75 MB +14 Bytes

Baseline commit: 751fc73

Generated by 🚫 dangerJS against 17a124c

@anthony-murphy anthony-murphy merged commit b7355f7 into microsoft:main Dec 2, 2023
24 checks passed
@anthony-murphy anthony-murphy deleted the beta-tag-loader-class-common branch November 13, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
base: main PRs targeted against main branch fluid2alpha Tag to track discussions related to the Fluid 2.0 release public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants