Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'RedeemFallback' demoted to regular telemetry event #18352

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

andre4i
Copy link
Contributor

@andre4i andre4i commented Nov 16, 2023

Description

This error event is currently the noisiest and I don't believe it is actionable as an error.

Not sure of its usefulness, but I would leave it as a regular telemetry event to maybe help with future investigations by correlating with other signals.

@andre4i andre4i requested review from a team as code owners November 16, 2023 22:30
@github-actions github-actions bot added area: driver Driver related issues area: odsp-driver base: main PRs targeted against main branch labels Nov 16, 2023
@andre4i andre4i requested review from vladsud and jatgarg November 16, 2023 22:32
@msfluid-bot
Copy link
Collaborator

@fluid-example/bundle-size-tests: +16 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 447.53 KB 447.53 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 240.63 KB 240.63 KB No change
loader.js 165.11 KB 165.12 KB +2 Bytes
map.js 48.06 KB 48.06 KB No change
matrix.js 141.84 KB 141.84 KB No change
odspDriver.js 90.3 KB 90.3 KB +6 Bytes
odspPrefetchSnapshot.js 41.82 KB 41.83 KB +6 Bytes
sharedString.js 162.75 KB 162.75 KB No change
sharedTree2.js 275.15 KB 275.15 KB No change
Total Size 1.73 MB 1.73 MB +16 Bytes

Baseline commit: dff4019

Generated by 🚫 dangerJS against bbaa9e8

@jatgarg
Copy link
Contributor

jatgarg commented Nov 17, 2023

@andre4i Please make sure that sending error in Generic Telemetry event does not change its type to error and become same as ErrorEvent.

@andre4i andre4i merged commit 6524bb7 into microsoft:main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: driver Driver related issues area: odsp-driver base: main PRs targeted against main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants