Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree2: Better and more consistent field cursor support #18234

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

CraigMacomber
Copy link
Contributor

Description

This better formalizes the convention of using above root placeholder nodes, leverages this to provide field cursor builders, and makes cursor related function naming more consistent.

Breaking Changes

Some cursor related functions have been renamed and had argument order changed, but nothing was removed.

Reviewer Guidance

The review process is outlined on this wiki page.

@CraigMacomber CraigMacomber requested review from a team as code owners November 9, 2023 18:28
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: tree public api change Changes to a public API base: main PRs targeted against main branch labels Nov 9, 2023
@msfluid-bot
Copy link
Collaborator

msfluid-bot commented Nov 9, 2023

@fluid-example/bundle-size-tests: +8 Bytes
Metric NameBaseline SizeCompare SizeSize Diff
aqueduct.js 447.51 KB 447.51 KB No change
connectionState.js 680 Bytes 680 Bytes No change
containerRuntime.js 240.61 KB 240.61 KB No change
loader.js 178.94 KB 178.94 KB No change
map.js 48.06 KB 48.06 KB No change
matrix.js 141.84 KB 141.84 KB No change
odspDriver.js 90.27 KB 90.27 KB No change
odspPrefetchSnapshot.js 41.9 KB 41.9 KB No change
sharedString.js 162.75 KB 162.75 KB No change
sharedTree2.js 263.51 KB 263.51 KB +8 Bytes
Total Size 1.72 MB 1.72 MB +8 Bytes

Baseline commit: 4892249

Generated by 🚫 dangerJS against 6063030

Copy link
Contributor

@Josmithr Josmithr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of documentation nitpicks. Otherwise looks good to me!

@CraigMacomber CraigMacomber merged commit ed4ffda into microsoft:main Nov 9, 2023
@CraigMacomber CraigMacomber deleted the FieldCursor branch November 9, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dds: tree area: dds Issues related to distributed data structures base: main PRs targeted against main branch public api change Changes to a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants