-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree2: Better and more consistent field cursor support #18234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⯅ @fluid-example/bundle-size-tests: +8 Bytes
Baseline commit: 4892249 |
Josmithr
reviewed
Nov 9, 2023
Josmithr
reviewed
Nov 9, 2023
experimental/dds/tree2/src/feature-libraries/treeCursorUtils.ts
Outdated
Show resolved
Hide resolved
Josmithr
reviewed
Nov 9, 2023
Josmithr
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of documentation nitpicks. Otherwise looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: dds: tree
area: dds
Issues related to distributed data structures
base: main
PRs targeted against main branch
public api change
Changes to a public API
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This better formalizes the convention of using above root placeholder nodes, leverages this to provide field cursor builders, and makes cursor related function naming more consistent.
Breaking Changes
Some cursor related functions have been renamed and had argument order changed, but nothing was removed.
Reviewer Guidance
The review process is outlined on this wiki page.