You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CreateContainerError was largely the inspiration for annotateError, the idea being it takes arbitrary input and coerces it to an IErrorBase - notably containing an errorType.
During the design phase (see #6676) we realized that we only should wrap errors when there's a new abstraction we're trying to achieve, e.g. for ContainerWarnings. But that's not the case for CreateContainerError - we're really just trying to ensure it has the right shape/features for logging. annotateError will provide all this functionality as of #6750. This issue will probably be fixed in the same PR but calling it out as a specific improvement to make.
The text was updated successfully, but these errors were encountered:
Update: We've decided there's no value in preserving the original shape/instance of an untrusted error, so CreateContainerError will still "wrap" untrusted errors - but it'll do it via normalizeError, which returns as-is if the error is of a known shape (IFluidErrorBase).
CreateContainerError
was largely the inspiration forannotateError
, the idea being it takes arbitrary input and coerces it to anIErrorBase
- notably containing anerrorType
.During the design phase (see #6676) we realized that we only should wrap errors when there's a new abstraction we're trying to achieve, e.g. for ContainerWarnings. But that's not the case for
CreateContainerError
- we're really just trying to ensure it has the right shape/features for logging.annotateError
will provide all this functionality as of #6750. This issue will probably be fixed in the same PR but calling it out as a specific improvement to make.The text was updated successfully, but these errors were encountered: