Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update annotateError to coerce the input to IFluidErrorBase #6750

Closed
markfields opened this issue Jul 15, 2021 · 1 comment · Fixed by #6764
Closed

Update annotateError to coerce the input to IFluidErrorBase #6750

markfields opened this issue Jul 15, 2021 · 1 comment · Fixed by #6764
Assignees
@markfields
Labels
telemetry
Milestone
July 2021

Comments

@markfields
Copy link
Member

markfields commented Jul 15, 2021 •
edited
Loading

annotateError normalizeError is the chokepoint we want to use to handle arbitrary error input, and after calling it we should get a well-formed IFluidErrorBase for further analysis.
@markfields markfields self-assigned this Jul 15, 2021
@markfields markfields added this to the July 2021 milestone Jul 15, 2021
This was referenced Jul 15, 2021
Closed
Merged
@markfields
Copy link
Member Author

annotateError is gone - We agreed there's no value in preserving the original shape/instance of an untrusted error, so annotateError was set aside in favor of normalizeError.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markfields markfields

Labels
telemetry
Projects
None yet
Milestone
July 2021
1 participant
@markfields