build: Upgrade pipelines to Node18 + upgrade nvm recommendation (#17389)

(Cherry pick of a0368d6)

Update the recommended versions of Node.js for developers to use, as
well as the version used by CI, from version 14 to 18.

This change made some scenarios in some e2e tests hang, so a fix for
skipping them had to be included.
Details:
0.58.x doesn't have the fix to routerlicious-driver in this PR:
#8913
(also see related issue for more context on the problem:
#9163)
This causes this test to hang while loading container2, as the snapshot
is over 16KB.

.nvmrc

@@ -1 +1 @@
-14
+18

PACKAGES.md

@@ -135,7 +135,7 @@ The dependencies between layers are enforced by the layer-check command._
 
 | Packages | Layer Dependencies |
 | --- | --- |
-| - [@fluidframework/azure-local-service](/server/azure-local-service)</br>- [tinylicious](/server/tinylicious)</br>&nbsp;</br>&nbsp;</br>&nbsp;</br>&nbsp; | - [Base-Definitions](#Base-Definitions)</br>- [Protocol-Definitions](#Protocol-Definitions)</br>- [Base-Utils](#Base-Utils)</br>- [Protocol-Utils](#Protocol-Utils)</br>- [Server-Shared-Utils](#Server-Shared-Utils)</br>- [Server-Libs](#Server-Libs) |
+| - [@fluidframework/azure-local-service](/azure/packages/azure-local-service)</br>- [tinylicious](/server/tinylicious)</br>&nbsp;</br>&nbsp;</br>&nbsp;</br>&nbsp; | - [Base-Definitions](#Base-Definitions)</br>- [Protocol-Definitions](#Protocol-Definitions)</br>- [Base-Utils](#Base-Utils)</br>- [Protocol-Utils](#Protocol-Utils)</br>- [Server-Shared-Utils](#Server-Shared-Utils)</br>- [Server-Libs](#Server-Libs) |
 
 ### Routerlicious-Driver
 

examples/apps/spaces/tsconfig.json

@@ -1,14 +1,13 @@
 {
     "extends": "@fluidframework/build-common/ts-common-config.json",
-    "exclude": [
-        "dist",
-        "node_modules"
-    ],
+    "exclude": ["dist", "node_modules"],
     "compilerOptions": {
         "target": "es6",
         "declarationDir": "./dist",
         "outDir": "./dist",
         "jsx": "react",
+        // Added because upgrading to node 18 caused a bunch of typecheck errors
+        "skipLibCheck": true,
         "types": [
             "jest",
             "puppeteer",
@@ -18,7 +17,5 @@
             "react-dom"
         ]
     },
-    "include": [
-        "src/**/*"
-    ]
+    "include": ["src/**/*"]
 }

examples/apps/view-framework-sampler/src/views/reactView.tsx

@@ -20,7 +20,7 @@ interface IDiceRollerViewProps {
     model: IDiceRoller;
 }
 
-export const DiceRollerView: React.FC<IDiceRollerViewProps> = (props: IDiceRollerViewProps) => {
+export const DiceRollerView = (props: IDiceRollerViewProps) => {
     const [diceValue, setDiceValue] = React.useState(props.model.value);
 
     React.useEffect(() => {

examples/apps/view-framework-sampler/tsconfig.json

@@ -8,6 +8,8 @@
         "module": "esnext",
         "outDir": "dist",
         "jsx": "react",
+        // Added because upgrading to node 18 caused a bunch of typecheck errors
+        "skipLibCheck": true,
         "types": [
             "jest",
             "puppeteer",

examples/data-objects/prosemirror/package.json

@@ -56,20 +56,20 @@
     "@fluidframework/sequence": "^1.4.0",
     "@fluidframework/view-adapters": "^1.4.0",
     "@fluidframework/view-interfaces": "^1.4.0",
-    "@types/prosemirror-model": "^1.7.2",
-    "@types/prosemirror-schema-list": "^1.0.1",
-    "@types/prosemirror-state": "^1.2.3",
-    "@types/prosemirror-view": "^1.9.0",
+    "@types/prosemirror-model": "1.16.2",
+    "@types/prosemirror-schema-list": "1.0.3",
+    "@types/prosemirror-state": "1.3.0",
+    "@types/prosemirror-view": "1.23.3",
     "orderedmap": "^1.1.1",
-    "prosemirror-example-setup": "^1.0.1",
-    "prosemirror-history": "^1.1.3",
-    "prosemirror-keymap": "^1.1.3",
-    "prosemirror-menu": "^1.2.1",
-    "prosemirror-model": "^1.7.2",
-    "prosemirror-schema-list": "^1.0.3",
-    "prosemirror-state": "^1.2.4",
-    "prosemirror-transform": "^1.2.3",
-    "prosemirror-view": "^1.10.3"
+    "prosemirror-example-setup": "1.1.2",
+    "prosemirror-history": "1.3.0",
+    "prosemirror-keymap": "1.2.0",
+    "prosemirror-menu": "1.2.1",
+    "prosemirror-model": "1.17.0",
+    "prosemirror-schema-list": "1.2.0",
+    "prosemirror-state": "1.4.0",
+    "prosemirror-transform": "1.6.0",
+    "prosemirror-view": "1.25.0"
   },
   "devDependencies": {
     "@fluid-tools/webpack-fluid-loader": "^1.4.0",

examples/data-objects/vltava/tsconfig.json

@@ -9,6 +9,8 @@
         "module": "esnext",
         "outDir": "dist",
         "jsx": "react",
+        // Added because upgrading to node 18 caused a bunch of typechecks errors
+        "skipLibCheck": true,
         "types": [
             "jest",
             "puppeteer",

experimental/PropertyDDS/packages/property-changeset/package.json

@@ -83,7 +83,7 @@
     "cross-env": "^7.0.2",
     "eslint": "~8.6.0",
     "mocha": "^10.0.0",
-    "nock": "^10.0.1",
+    "nock": "^13.3.3",
     "nyc": "^15.0.0",
     "rimraf": "^2.6.2",
     "sinon": "^7.4.2",

experimental/PropertyDDS/packages/property-common/package.json

@@ -82,7 +82,7 @@
     "cross-env": "^7.0.2",
     "eslint": "~8.6.0",
     "mocha": "^10.0.0",
-    "nock": "^10.0.1",
+    "nock": "^13.3.3",
     "nyc": "^15.0.0",
     "rimraf": "^2.6.2",
     "sinon": "^7.4.2",

experimental/PropertyDDS/packages/property-properties/package.json

@@ -80,7 +80,7 @@
     "cross-env": "^7.0.2",
     "eslint": "~8.6.0",
     "mocha": "^10.0.0",
-    "nock": "^10.0.1",
+    "nock": "^13.3.3",
     "nyc": "^15.0.0",
     "rimraf": "^2.6.2",
     "sinon": "^7.4.2",

experimental/PropertyDDS/packages/property-query/package.json

@@ -40,7 +40,7 @@
     "chai": "^4.2.0",
     "cross-env": "^7.0.2",
     "mocha": "^10.0.0",
-    "nock": "^10.0.1",
+    "nock": "^13.3.3",
     "nyc": "^15.0.0",
     "sinon": "^7.4.2"
   }