Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose IFeatureFilter #29

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

zhiyuanliang-ms
Copy link
Contributor

@zhiyuanliang-ms zhiyuanliang-ms commented Aug 20, 2024

Why this PR?

IFeatureFilter should be exported so that users can implement customized feature filter.

@zhiyuanliang-ms zhiyuanliang-ms changed the title Expose i feature filter & Add .js extension to import file Expose IFeatureFilter & Add .js extension to import file Aug 20, 2024
@Eskibear
Copy link
Member

should separate into two PRs

  • export type
  • migrate to ESM style

@zhiyuanliang-ms zhiyuanliang-ms force-pushed the zhiyuanliang/expose-IFeatureFilter branch from bae8389 to 6eae073 Compare August 20, 2024 08:37
@zhiyuanliang-ms zhiyuanliang-ms changed the title Expose IFeatureFilter & Add .js extension to import file Add .js extension to import file Aug 20, 2024
@zhiyuanliang-ms zhiyuanliang-ms force-pushed the zhiyuanliang/expose-IFeatureFilter branch from 6eae073 to 779c01b Compare August 20, 2024 09:03
@zhiyuanliang-ms zhiyuanliang-ms changed the title Add .js extension to import file Expose IFeatureFilter Aug 20, 2024
@zhiyuanliang-ms zhiyuanliang-ms merged commit 122bb9b into main Aug 21, 2024
3 checks passed
@zhiyuanliang-ms zhiyuanliang-ms deleted the zhiyuanliang/expose-IFeatureFilter branch August 21, 2024 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants