-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
validate property types of feature flags #17
Conversation
This PR will not close #14. After we support telemetry and variant, we need to validate their properties. |
00c8992
to
19bb405
Compare
618c7a6
to
917d7f0
Compare
@Eskibear @linglingye001 I am thinking whether the validation is too much. In our current implementation, the validation will happen during each call of In .NET FM, the validation will only happen once, because feature flag provider has a cache mechanism (but we don't have that and I am also wondering whether it is possible to have that because we cannot know whether the configuration changed so that we can refresh the cache.) So, I am thinking maybe we can add an option to disable the feature flag validation. As long as the feature flag is from app config, we should have the confidence that feature flags are in the correct shape. |
Except the comments I left, this PR looks good to me. |
@zhiyuanliang-ms do you want me to update the PR or you take it over? |
@Eskibear I asked @linglingye001 to take over this PR. Did you notice that lingling has pushed a lot of commits? |
b21ee4a
to
a8c548e
Compare
See #14
It validates property types based on the feature flag JSON schema.