New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evaluate method signature in TargetingFilter.ts #10

Merged

Eskibear merged 1 commit into main from yanzh/targeting-filter-return-type

Apr 17, 2024

Member

Eskibear commented Apr 17, 2024 •

edited

Loading

Impl of TargetingFilter.evaluate is not async. Fix the signature to eliminate confusion.

See #5 (comment)


          Fix evaluate method signature in TargetingFilter.ts

4bef60d

Eskibear requested review from avanigupta, juniwang, rossgrambo and zhiyuanliang-ms

April 17, 2024 07:51

zhiyuanliang-ms approved these changes

View reviewed changes

rossgrambo approved these changes

View reviewed changes

Eskibear merged commit 382dd86 into main

1 check passed

Eskibear deleted the yanzh/targeting-filter-return-type branch

April 17, 2024 23:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet