Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use decorator for "register_auto_reply" #1176

Closed
wants to merge 5 commits into from
Closed

Use decorator for "register_auto_reply" #1176

wants to merge 5 commits into from

Conversation

BeibinLi
Copy link
Collaborator

@BeibinLi BeibinLi commented Aug 4, 2023

Use decorator to simply the auto reply function registration.

Why are these changes needed?

Related issue number

Checks

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the registration more convenient. Could you also modify the chess notebook?
Also, could you add a test for a class inheriting two subclasses of ResponsiveAgent and make the registration works as expected?

flaml/autogen/agentchat/responsive_agent.py Show resolved Hide resolved
flaml/autogen/agentchat/responsive_agent.py Outdated Show resolved Hide resolved
flaml/autogen/agentchat/responsive_agent.py Show resolved Hide resolved
@sonichi sonichi requested review from ekzhu, qingyun-wu, gagb and a team August 5, 2023 16:06
@sonichi sonichi linked an issue Aug 5, 2023 that may be closed by this pull request
@sonichi sonichi mentioned this pull request Aug 7, 2023
3 tasks
@BeibinLi
Copy link
Collaborator Author

BeibinLi commented Aug 7, 2023

Thanks for making the registration more convenient. Could you also modify the chess notebook? Also, could you add a test for a class inheriting two subclasses of ResponsiveAgent and make the registration works as expected?

Test cases added and suggestions resolved.

TODO:

  • Handle the Chess example.

@BeibinLi BeibinLi closed this Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use Python decorator to simplify the registration process
2 participants