Fix for liquid filter timezone handling #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonheld-msft
changed the title
|
@ginalee-dotcom Hi Gina, Could you please help to check this issue about the default behavior for FormatAsDateTime filter. "Preserve" means preserve the original time zone and "local" means transform the input into local time. "Preserve" is more reasonable here but may lead to breaking change. |
sowu880
approved these changes
Mar 22, 2022
|
Thanks a lot for the suggestion. |
jakiefermsft
added a commit
to jasonheld-msft/FHIR-Converter
that referenced
this pull request
Apr 26, 2022
…fer/pgcritiques-merge * 'main' of github.com:microsoft/FHIR-Converter: Global Readiness Manifest file GeoPol.xml Update version (microsoft#375) Remove blank lines (microsoft#374) Update Doc for Filters (microsoft#365) Switch FormatAsDateTime timezone handling to preserve to maintain consistency (microsoft#358) Revert "reset to local (microsoft#368)" reset to local (microsoft#368) Phase -2, Milestone-3 Mapping (microsoft#366) Change Default Time Zone Handling (microsoft#363) Turn on mac functional test check (microsoft#367) Fix warnings (microsoft#364) Fix Time Zone Bug (microsoft#353) Phase2 - Milestone 1&2 Mapping (microsoft#354) Add check for large for loops (microsoft#361) Updated the logic of checking the number of default templates Update pipeline win host version (microsoft#359)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, all date filters except FormatAsDateTime default to "preserve". With a default of "local", all functional tests seem to fail depending on what timezone they are run in. My assumption is that by default the time would not want to be changed when converting to FHIR.