Add a new filter - splitDataBySegments #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoyaWu10
reviewed
Dec 21, 2021
src/Microsoft.Health.Fhir.Liquid.Converter/Utilities/Hl7v2DataUtility.cs
Outdated
Show resolved
Hide resolved
qiwjin
reviewed
Dec 21, 2021
| var result = new Hl7v2Data(); | ||
| var segmentIds = segmentIdSeparators.Split(@"|", StringSplitOptions.RemoveEmptyEntries); | ||
|
|
||
| if (segmentIdSeparators == string.Empty || segmentIds.Intersect(hl7v2Data.Meta).ToList().Count == 0) |
There was a problem hiding this comment.
use .any() instead of .count==0
There was a problem hiding this comment.
Updated it.
qiwjin
reviewed
Dec 21, 2021
|
|
||
| for (var i = 0; i < hl7v2Data.Meta.Count; ++i) | ||
| { | ||
| if (segmentIds.Contains(hl7v2Data.Meta[i])) |
There was a problem hiding this comment.
try to use hashset instead of array of string?
There was a problem hiding this comment.
Updated it. It would be better.
qiwjin
approved these changes
Dec 21, 2021
BoyaWu10
approved these changes
Dec 21, 2021
yankunhuang-pku
deleted the
personal/yankhuan/add-filter-splitDataBySegments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.