[DotLiquid] Add TraceInfo for HL7 v2 conversion #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BoyaWu10
requested review from
ACMoretxj,
qiwjin,
sowu880,
moria97 and
yankunhuang-pku
BoyaWu10
force-pushed
the
personal/boywu/unused-segments
branch
from
6fbfcb9
to
a365ccc
Compare
qiwjin
reviewed
Dec 9, 2020
src/Microsoft.Health.Fhir.Liquid.Converter/Hl7v2/Models/UnusedHl7v2Field.cs
Outdated
Show resolved
Hide resolved
moria97
reviewed
Dec 9, 2020
src/Microsoft.Health.Fhir.Liquid.Converter.Tool/ConverterLogicHandler.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Liquid.Converter/Hl7v2/Models/Hl7v2TraceInfo.cs
Outdated
Show resolved
Hide resolved
moria97
approved these changes
Dec 10, 2020
BoyaWu10
commented
Dec 11, 2020
qiwjin
reviewed
Dec 11, 2020
| @@ -7,7 +7,7 @@ namespace Microsoft.Health.Fhir.Liquid.Converter.Models | |||
| { | |||
| /// <summary> | |||
| /// TraceInfo records processing details during conversion. | |||
| /// It is going to be implemented in coming releases. | |||
| /// For HL7 v2 conversion, please use its inherited class Hl7v2TraceInfo. | |||
There was a problem hiding this comment.
also consider ccda case if any shared field or method.
There was a problem hiding this comment.
Yes, would it be better if we simplify the output to "UnusedLines" and "UnusedIntervals" and make them shared for both HL7 v2 and CCDA?
src/Microsoft.Health.Fhir.Liquid.Converter/Hl7v2/Models/UnusedHl7v2Component.cs
Outdated
Show resolved
Hide resolved
yankunhuang-pku
approved these changes
Dec 11, 2020
ACMoretxj
approved these changes
Dec 11, 2020
sowu880
approved these changes
Dec 14, 2020
…icrosoft/FHIR-Converter into personal/boywu/unused-segments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add TraceInfo for HL7 v2 conversion. If (a)
-tis specified in command-line tool or (b)Hl7v2TraceInfois passed in conversion interface, TraceInfo will be provided along with conversion result. Currently, TraceInfo contains unused segments.Some other changes in this PR:
ConverterLogicHandler, as the one in template management.RenderParameters.FromContextwhich is provided directly in DotLiquid.SafeListenumerable..editorconfigin solution items, as suggested by IDE.Related issues
Addresses [issue #].
Testing
Describe how this change was tested.