Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @arethetypeswrong/cli run to dtslint #811

Merged
merged 40 commits into from
Jan 30, 2024
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
48333e8
Add @arethetypeswrong/cli
andrewbranch Nov 4, 2023
1f74e7e
Remove lint disable even though it errors on my machine
andrewbranch Nov 4, 2023
b18f32c
Satisfy eslint even though it’s wrong
andrewbranch Nov 4, 2023
4bfc27f
Add changeset
andrewbranch Nov 4, 2023
7c4fcd1
Use execFileSync
andrewbranch Nov 6, 2023
ca60675
Set COREPACK_ENABLE_STRICT=0 on npm pack
andrewbranch Nov 6, 2023
0e73c88
Don’t run attw when `expectOnly` is set
andrewbranch Nov 6, 2023
75b216e
Add flag to disable attw
andrewbranch Nov 6, 2023
21d7e2a
Add attw core as dependency
andrewbranch Dec 13, 2023
cb2059e
Merge branch 'main' into attw
andrewbranch Dec 18, 2023
714c271
Revert pnpm-lock change from merge
andrewbranch Dec 18, 2023
17bd1a4
Recreate pnpm-lock change
andrewbranch Dec 18, 2023
e489d4d
WIP
andrewbranch Jan 19, 2024
73dfdee
Merge branch 'main' into attw
andrewbranch Jan 19, 2024
394b86d
Delete npm-naming, combine skipNpmNaming and noAttw options
andrewbranch Jan 19, 2024
0d930f7
Fix missing await
andrewbranch Jan 23, 2024
6de7d4c
Fix more memory leak
andrewbranch Jan 24, 2024
b240838
Update attw
andrewbranch Jan 24, 2024
7cd9dd3
Add expectedNpmVersionFailures, collate warnings and errors
andrewbranch Jan 25, 2024
4594e74
Merge branch 'main' into attw
andrewbranch Jan 25, 2024
1060d5c
Delete unused dts-critic function
andrewbranch Jan 25, 2024
2fc2e83
Fix snapshot
andrewbranch Jan 25, 2024
b5ac2e8
Capture package versions in expectedNpmVersionFailures and related error
andrewbranch Jan 25, 2024
d055dc1
Note when a package can be removed from expectedNpmVersionFailures.txt
andrewbranch Jan 25, 2024
1e78599
Update message
andrewbranch Jan 25, 2024
4a9e458
Prefer pnpm for tarball packing
andrewbranch Jan 25, 2024
71dd6d4
Run knip --fix
andrewbranch Jan 25, 2024
ca08243
Ignore unused file we might use again soon
andrewbranch Jan 25, 2024
f1e442d
Regenerate changeset
andrewbranch Jan 25, 2024
54b244d
Use execFileSync instead of execSync
andrewbranch Jan 25, 2024
c3355d3
Fix execFileSync format
andrewbranch Jan 25, 2024
e213ba0
Drop baseConfig
andrewbranch Jan 25, 2024
c763ac2
Don’t assume a specific format for pnpm/npm pack filename other than …
andrewbranch Jan 25, 2024
81aafe6
Simplify `=== false` check
andrewbranch Jan 25, 2024
c844ec9
Use tmp library instead of os.tmpdir
andrewbranch Jan 25, 2024
762e1a8
Fix tmpDir usage
andrewbranch Jan 25, 2024
e16bd73
Move most logic to checks.ts
andrewbranch Jan 25, 2024
ba271dc
tmp.setGracefulCleanup()
andrewbranch Jan 25, 2024
25bbd54
Add gamedig to npm version exemptions
andrewbranch Jan 30, 2024
f1c2645
Merge branch 'main' into attw
andrewbranch Jan 30, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changeset/big-hotels-pay.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
"@definitelytyped/dtslint-runner": patch
"@definitelytyped/eslint-plugin": patch
"@definitelytyped/header-parser": patch
"@definitelytyped/dts-critic": patch
"@definitelytyped/dtslint": patch
---

Add @arethetypeswrong/cli run
3 changes: 2 additions & 1 deletion .knip.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
"packages/eslint-plugin": {
"entry": "src/index.ts",
"project": "**/*.ts",
"ignoreDependencies": ["@definitelytyped/eslint-plugin"]
"ignoreDependencies": ["@definitelytyped/eslint-plugin"],
"ignore": ["**/suggestions.ts"]
},
"packages/header-parser": {
"entry": "src/index.ts",
Expand Down
9 changes: 0 additions & 9 deletions packages/dts-critic/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,15 +68,6 @@ If your declaration is for a non-npm package (in other words, if your declaratio

Note that for real use on Definitely Typed, a lot of these checks need to be pretty loose.

# Also

```sh
$ node dist/dt.js
```

Will run dts-critic on every directory inside `../DefinitelyTyped` and
print errors.

# Contributing

## Testing
Expand Down
Loading
Loading