Deepspeed-Domino #929
Merged
Deepspeed-Domino #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangsmallshark
requested review from
tjruwase,
awan-10,
eltonzheng,
duli2012 and
arashb
as code owners
GuanhuaWang
reviewed
Sep 26, 2024
GuanhuaWang
reviewed
Sep 26, 2024
GuanhuaWang
reviewed
Sep 26, 2024
GuanhuaWang
reviewed
Sep 26, 2024
GuanhuaWang
reviewed
Sep 26, 2024
GuanhuaWang
reviewed
Sep 26, 2024
GuanhuaWang
reviewed
Sep 26, 2024
GuanhuaWang
reviewed
Sep 26, 2024
GuanhuaWang
reviewed
Sep 26, 2024
GuanhuaWang
reviewed
Sep 26, 2024
GuanhuaWang
reviewed
Sep 26, 2024
There was a problem hiding this comment.
Thx @zhangsmallshark and @shenzheyu for great work.
added a few high level comments, we need to make loss and iter time both fixed! thx
|
@zhangsmallshark , regarding to fix loss commit da0c63b Maybe I miss something, but I don't see any real code change regarding to fwd/bwd/step. The only changes in this commit just add timers, comment some printout vals. idk how loss is fixed in this commit |
tjruwase
reviewed
Oct 16, 2024
tjruwase
reviewed
Oct 16, 2024
tjruwase
reviewed
Oct 29, 2024
tjruwase
reviewed
Oct 29, 2024
shenzheyu
reviewed
Nov 6, 2024
|
@tjruwase Hi Olatunji, we've resolved all the comments. Could you please help us by starting the final review? |
tjruwase
approved these changes
Nov 7, 2024
LGTM! Thanks! |
tjruwase
reviewed
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello team, Deepspeed-Domino contains all related files for Domino project.