Refactor deepspeed-chat into a python package. #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-fevieira
requested review from
jeffra,
samyam,
tjruwase,
ShadenSmith,
conglongli,
awan-10,
eltonzheng,
minjiaz,
RezaYazdaniAminabadi,
duli2012,
mrwyattii,
yaozhewei,
arashb and
xiaoxiawu-microsoft
as code owners
Microsoft master fix merge conflicts
awan-10
reviewed
Oct 18, 2023
applications/DeepSpeed-Chat/setup.py
Outdated
| url= | ||
| "https://github.com/microsoft/DeepSpeedExamples/tree/master/applications/DeepSpeed-Chat", | ||
| include_package_data=True, | ||
| packages=setuptools.find_packages(include=['deepspeed_chat']), |
There was a problem hiding this comment.
Let's name the package deepspeed-chat (There is a package named deepspeed-mii) so let's follow the convention of hyphen instead of underscore.
There was a problem hiding this comment.
@jeffra and I discussed this a bit. Let me write what we decided here. PyPI name will be deepspeed-chat and the python package will be dschat since python imports won't work with hyphens
loadams
reviewed
Nov 2, 2023
| import setuptools | ||
|
|
||
| setuptools.setup( | ||
| name="deepspeed-chat", |
There was a problem hiding this comment.
@mrwyattii - looks like we are thinking of making this into a python package, should we add scripts to publish this then?
lekurile
approved these changes
Nov 2, 2023
jeffra
reviewed
Nov 6, 2023
| install_requires=[ | ||
| "datasets>=2.8.0", "sentencepiece>=0.1.97", "protobuf==3.20.3", | ||
| "accelerate>=0.15.0", "torch>=1.12.0", "deepspeed>=0.9.2", | ||
| "transformers", "tensorboard" |
There was a problem hiding this comment.
I believe our transformers dependency here is not open, looking at the original requirements.txt that is:
mrwyattii
pushed a commit
to microsoft/DeepSpeed
that referenced
this pull request
Nov 8, 2023
This PR updates the ds-chat workflow to work with the `deepspeed-chat` install once this PR completes in DeepSpeedExamples: microsoft/DeepSpeedExamples#731 Manual workflow run: https://github.com/microsoft/DeepSpeed/actions/runs/6738638809/job/18318636818
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
…4598) This PR updates the ds-chat workflow to work with the `deepspeed-chat` install once this PR completes in DeepSpeedExamples: microsoft/DeepSpeedExamples#731 Manual workflow run: https://github.com/microsoft/DeepSpeed/actions/runs/6738638809/job/18318636818
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.