Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hybrid Engine mode + move arguments to a file #684

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

awan-10
Copy link
Contributor

@awan-10 awan-10 commented Aug 11, 2023

No description provided.

Copy link
Contributor

@lekurile lekurile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning this up!

dtype=data_type,
mp_size=args.world_size,
replace_with_kernel_inject=args.use_kernel,
max_tokens=args.max_tokens,
save_mp_checkpoint_path=args.save_mp_checkpoint_path,
**ds_kwargs
)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra whitespace.

@awan-10 awan-10 merged commit 78a8e2d into master Aug 11, 2023
2 checks passed
LeetJoe pushed a commit to LeetJoe/DeepSpeedExamples that referenced this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants