-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address memory leaks #782
Address memory leaks #782
Conversation
First pass looks really good. I will check it out again tomorrow. Two things I would like to see.
Next step is to get the final .NET fix in as well. We should try and validate that leak scenario still exists. I believe the easiest way is to use the |
(YAY!) |
…to resurrect reference tracker.
The 26 WinUI lifetime tests now all pass. |
@manodasanW Any luck trying to use that? |
@AaronRobinsonMSFT that is on my list to try out and will get back to you once I do. |
The changes in this PR addresses the memory leaks observed in the samples from #781. It is a variant of the changes attempted initially in #673 , but addresses some of the concerns about finalizers on the RCW handling release by moving that to the IObjectReference itself which owns the lifetime. In addition, it makes sure in aggregated scenarios, any QIs don't increment the COM ref count maintained by the CLR and that for non aggregated scenarios XAML is informed of those references.
From testing, these changes seem to demonstrate an improvement and no leaks are observed in the samples in #781
Fixes #413