Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements to 'ExceptionHelpers.SetErrorInfo' #1824

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Minor improvements to 'ExceptionHelpers.SetErrorInfo' #1824

merged 3 commits into from
Oct 22, 2024

Conversation

Sergio0694
Copy link
Member

This PR includes just a couple of tweaks to ExceptionHelpers.SetErrorInfo:

  • Use WindowsCreateStringReference, since we can just pin the source text.
  • Avoid allocating a temporary IObjectReference object.

@Sergio0694 Sergio0694 added performance Related to performance work gc Related to garbage collection labels Oct 14, 2024
@Sergio0694 Sergio0694 requested a review from manodasanW October 14, 2024 05:52
@Sergio0694 Sergio0694 force-pushed the user/sergiopedri/exception-tweaks branch from bd0b721 to 0327e44 Compare October 14, 2024 05:52
@manodasanW manodasanW merged commit 13ea06c into master Oct 22, 2024
10 checks passed
@manodasanW manodasanW deleted the user/sergiopedri/exception-tweaks branch October 22, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manodasanW manodasanW manodasanW approved these changes

Assignees
No one assigned
Labels
gc Related to garbage collection performance Related to performance work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sergio0694 @manodasanW