Add MarshalString.FromAbiUnsafe API #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sergio0694
added
enhancement
Sergio0694
force-pushed
the
user/sergiopedri/from-abi-unsafe
branch
from
c4b170d to
c6b0708
Compare
Sergio0694
force-pushed
the
user/sergiopedri/from-abi-unsafe
branch
from
c6b0708 to
1818410
Compare
|
@manodasanW the test failure in Debug x64 seems unrelated, maybe transient? Could you re-trigger that CI job? 🙂 |
manodasanW
reviewed
Nov 30, 2023
manodasanW
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1399
Description
This PR adds a new
MarshalStringAPI:This allows marshalling an
HSTRINGto aReadOnlySpan<char>value, without allocating a temporarystring. The "Unsafe" suffix matches the naming convention in the BCL for methods that are not safe when misused. In this case, callers have to make sure not to escape the returnedReadOnlySpan<char>value outside of the scope where theHSTRINGis valid.Developers can use this where appropriate, and we can also use this in eg. marshalling stubs in the future. Once we update the projections to require C# 11, we can also restore #1399 and leverage this API there as well.