Fix non-generic ICollection interface calls not working #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ujjwalchadha
approved these changes
Mar 16, 2023
jamespik
approved these changes
Mar 16, 2023
jlaanstra
approved these changes
Mar 16, 2023
dongle-the-gadget
pushed a commit
to dongle-the-gadget/CsWinRT
that referenced
this pull request
Jul 29, 2023
* Fix IDIC casts not working with ICollection interface given we didn't have adapter for it. * Test seems to be passing after past IDIC refactor. * Add more tests and fix issue with Clear * Handle IDIC cast to ICollection and fix namespaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously had support for handling the ICollection<> interface. But we were missing the non-generic ICollection interface. This causes IDIC casts to that interface to fail which is used by IList. Resolving it by handling it similarly to ICollection<> via our IDIC hybrid collection support.
Note, I did a review of the other interfaces and found out that the non-generic IEnumerator might also be affected in some scenarios. Tracking that separately with #1302 given it has the possibility of requiring a change to our API surface.