Custom IWindowNative for ILTrimming #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Jun 29, 2022
manodasanW
reviewed
Jun 29, 2022
manodasanW
reviewed
Jun 29, 2022
manodasanW
reviewed
Jun 29, 2022
manodasanW
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support ILTrimming, we need to remove our dependency on ComImport for IWindowNative and IInitializeWithWindow. By replacing them with custom projections, we become trimmable. We should see some perf gains from this change because we do not require IDIC anymore (
.As<IWindowNative>()), and the ComImport itself probably had some overhead.