Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverse workaround for invalid template errors and apply fix #123

Merged
merged 5 commits into from
Aug 6, 2020

Conversation

denscollo
Copy link
Contributor

Fixes #122

Description

Fix the issue with invalid templates by using inner scope variables and reverse the workaround from the PR# 117 and PR# 118.

Specific changes

  • Reversed the main YAML to use the deploy template using a new resource group.
  • Removed step to create a new resource group in all main YAML as it is already created using the deploy template with new resource group.
  • Updated all the template-with-new-rg.json with the inner scope variable, declaration of the new variables in that scope, and used it.

Note: when referring to all main YAML we are excluding the one for JS host to JS skill and with all the template-with-new-rg.json we are excluding the ones for the JS bots as this changes were already added in the PR# 121.

Testing

All the pipelines were tested with these changes applied and were working properly.
image

Write-Output $content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes here.

@mrivera-ms mrivera-ms merged commit a7654f3 into master Aug 6, 2020
@gabog gabog deleted the southworks/fix/invalid-template-errors branch December 9, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reverse workaround for invalid template errors and apply fix
4 participants